Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary dep on criterion. #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sellout
Copy link

@sellout sellout commented Apr 17, 2022

This prevented Snårkl from being used with recent GHC.

This prevented Snårkl from being used with recent GHC.
@gstew5
Copy link
Owner

gstew5 commented Apr 18, 2022

I haven't been programming Haskell recently.

Is criterion now bundled with GHC?

It seems this library still depends on it (https://github.com/gstew5/snarkl/blob/d6ce72b13e370d2965bb226f28a1135269e7c198/src/testsuite/benchmarks/Main.hs).

@sellout
Copy link
Author

sellout commented Apr 18, 2022

The benchmark target (and the test-suite) still have a dependency on criterion, so if you use those you're still restricted to GHC 8.2. But downstream code can depend on the library without that, so this allows people to use snarkl at least up to GHC 9.0 now.

@sellout
Copy link
Author

sellout commented Oct 26, 2022

I realized my last comment might not be clear – this doesn’t break anything that has an actual dependency on criterion. The dependency is still in the cabal file for those targets. But the dependency wasn’t used on the snarkl library, so we can remove that dependency to allow snarkl to work with GHC 9 without impacting testing & benchmarking on GHC 8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants